Docs updates and cleanups#12401
Merged
zuercher merged 12 commits intoenvoyproxy:masterfrom Aug 28, 2020
Merged
Conversation
phlax
force-pushed
the
docs-updates-and-cleanups
branch
from
a0fd665 to
a6cc2e9
Compare
Fixes: envoyproxy#12231 Signed-off-by: Ryan Northey <ryan@synca.io>
- Use code-block:console - Link to container server Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docs-updates-and-cleanups
branch
from
a6cc2e9 to
d59f0d8
Compare
Member
|
Is this ready for review? |
Member
Author
|
not quite - should be ready in a day or 2 |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
Member
Author
|
bump - just finishing off tests (#12491) |
stale
bot
removed
the
stale
Member
|
Thanks. That all looks good to me. When you're ready, hit the "ready for review" button and the rest of the tests will run and we can get this approved. |
Member
Author
|
@zuercher apologies for the delay - there were some things i had wanted to finish off |
Member
|
You'll need to fix the DCO, and there's a format error: Otherwise, I think it looks good. |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docs-updates-and-cleanups
branch
from
5d1d8d0 to
25d87ca
Compare
clarakosi
pushed a commit
to clarakosi/envoy
that referenced
this pull request
Sep 3, 2020
Risk Level: low Testing: n/a Docs Changes: yes Release Notes: n/a Fixes envoyproxy#12231 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: Docs updates and cleanups
Additional Description:
Risk Level: low
Testing: see https://github.com/phlax/envoy-examples
Docs Changes: yes
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] #12231
[Optional Deprecated:]